Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pyropy
left a comment
There was a problem hiding this comment.
Hey @davidgasquez let's start a discussion on metrics here 🙌🏻
METRIC-DEFINITIONS.md
Outdated
| - **Formula:** `Σ(account.userTokens.lockupCurrent)` converted from wei (18 decimals) to USDFC | ||
| - **Note:** Same metric as GA Mode. Displayed between Active Payers and USDFC Settled. | ||
|
|
||
| #### Total Settled (USDFC) |
There was a problem hiding this comment.
Are we only interested in displaying USDFC settlement? What about native (FIL) settlements? Do we need separate metric for those?
There was a problem hiding this comment.
Is this also a duplicate metric (there is USDFC Settled (Cumulative) above)?
METRIC-DEFINITIONS.md
Outdated
| - **Formula:** `Σ(account.userTokens.lockupCurrent)` converted from wei (18 decimals) to USDFC | ||
| - **Note:** This represents the total amount of USDFC that has been deposited and is locked to secure active payment rails. Displayed between Active Payers and USDFC Settled. | ||
|
|
||
| #### USDFC Settled (Cumulative) |
There was a problem hiding this comment.
Are we interested in native token settlements?
|
@timfong888 I went over your dashboard prototype and reviewed some of the metrics and stuff displayed over there. It's more of a general feedback / questions on what we want to display as that will shape what we put into the METRICS-DEFINITIONS.md file Main page (Dashboard)
Payer accounts page
Payee accounts page
Payer Details
Payee details
cc @geomatrick I know Tim and you have worked on this quite a bit, so maybe you have also some feedback on what metrics we'd like to display? |
This reverts commit 54115f3.
METRIC-DEFINITIONS.md
Outdated
| ### Settled (7d) | ||
| - **Definition:** USDFC settled by this payer in the last 7 days | ||
| - **Source:** `Settlement` events filtered by payer address and timestamp | ||
| - **Formula:** `Σ(settlement.totalSettledAmount)` where `settlement.rail.payer.address == payerAddress AND timestamp >= now - 7 days` |
There was a problem hiding this comment.
| - **Formula:** `Σ(settlement.totalSettledAmount)` where `settlement.rail.payer.address == payerAddress AND timestamp >= now - 7 days` | |
| - **Formula:** `Σ(settlement.totalSettledAmount)` where `settlement.rail.payer.address == payerAddress AND settlement.rail.token == USDFC_ADDRESS AND timestamp >= now - 7 days` |
BigLep
left a comment
There was a problem hiding this comment.
I'm not a blocking approver here. I wanted to read it to be more aware of how things worked, but please feel free to proceed without further review from me.
METRIC-DEFINITIONS.md
Outdated
| - **Definition:** Total USDFC currently locked across all accounts for future payments | ||
| - **Source:** Sum of `Account.userTokens.lockupCurrent` from Goldsky subgraph | ||
| - **Formula:** `Σ(account.userTokens.lockupCurrent)` converted from wei (18 decimals) to USDFC | ||
| - **Note:** This represents the total amount of USDFC that has been deposited and is locked to secure active payment rails. Displayed between Active Payers and USDFC Settled. |
There was a problem hiding this comment.
I don't know what "Displayed between Active Payers and USDFC Settled" menas.
There was a problem hiding this comment.
Left a couple of questions. Thanks for opening starting the discussion @pyropy, it's been helpful
We should either leave total active payers chart or just display the number of total active payers, I don’t see the need for both
I think the chart might be "incorrect" as it is looking at the current state so historical values will change. It'll be always growing and monotonic even if from one day to another it goes down by 10 active payers.
METRIC-DEFINITIONS.md
Outdated
| - **Formula:** `Σ(account.userTokens.lockupCurrent)` converted from wei (18 decimals) to USDFC | ||
| - **Note:** Same metric as GA Mode. Displayed between Active Payers and USDFC Settled. | ||
|
|
||
| #### Total Settled (USDFC) |
There was a problem hiding this comment.
Is this also a duplicate metric (there is USDFC Settled (Cumulative) above)?
|
In case it is helpful, I'm working on the same metrics using the existing definition but deriving everyghing from the FEVM logs.
|
|
Linking this comment here. We might want to wait with metric definitions until we have subgraph ready. Depending on the subgraph formulas to get the metrics might change. As for definitions, we'd only need three:
|
|
@davidgasquez for myself to understand the stack, what is pipeline you have set up to use EVM Logs? REgarding the other questions, I belive the PDP verifier contract was where I found data size. It is not in the pay contract. |
I'm working on the pipeline but for now, Riba has published the result of the I'm ingesting these and then decoding all the events from any contract ABI I can get my hands into. That gives me all the events with their With this pipeline, I just need to tweak the SQL transformations and rerun it (1 second) to tweak the metrics. |

Adds GA metric definitions.
Closes #85
Blocked by: